Rework Ipv6Addr::is_global to check for global reachability rather than global scope
#86634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-io
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
CDirkx
commented
Jun 25, 2021
library/std/src/net/ip.rs
Outdated
Comment on lines
-477
to
+496
There was a problem hiding this comment.
Reworded to a (in my opinion) less cluttered non-exhaustive list. Instead of trying to list every type of address and exceptions, we list the most notable ones (mostly the ones Rust has methods for) and refer to the Special Address Registry for the complete overview. A similar thing is done in the description of Ipv6Addr::is_global.
CDirkx
commented
Jun 25, 2021
library/std/src/net/ip.rs
Outdated
Comment on lines
-550
to
+567
There was a problem hiding this comment.
Reordered the checks to match the order in the Special Address Registry.
CDirkx
commented
Jun 25, 2021
library/std/src/net/ip.rs
Outdated
There was a problem hiding this comment.
"globally reachable" instead of "globally routable", as that is the terminology used in the Special Address Registry.
CDirkx
commented
Jun 25, 2021
library/std/src/net/ip.rs
Outdated
There was a problem hiding this comment.
If you're not connected to the internet, you still can't reach a "globally reachable" address. I hope this also makes it clear that this method doesn't actually do any network traffic.
CDirkx
commented
Jun 25, 2021
library/std/src/net/ip.rs
Outdated
Comment on lines
+1235
to
+1239
There was a problem hiding this comment.
Trying to avoid the confusion between "globally reachable" and "global scope", the rename in #85696 from is_unicast_global to has_unicast_global_scope should hopefully help with this. Another possibility would be to rename is_global to is_globally_reachable.
CDirkx
commented
Jun 25, 2021
CDirkx
commented
Jun 25, 2021
library/std/src/net/ip/tests.rs
Outdated
Comment on lines
-308
to
+313
There was a problem hiding this comment.
As mentioned in the PR description, multicast addresses with non-global scope are actually still globally reachable.
This was referenced Jun 25, 2021
CDirkx
force-pushed
the
ip-globally-reachable
branch
from
dabff95 to
2be1e92
Compare
CDirkx
force-pushed
the
ip-globally-reachable
branch
from
2be1e92 to
9ddd5a5
Compare
|
Addressed an incorrect check pointed out in #86969 (comment) |
JohnCSimon
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #87535) made this pull request unmergeable. Please resolve the merge conflicts. |
camelid
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…plett Add `Ipv6Addr::is_benchmarking` This PR adds the unstable method `Ipv6Addr::is_benchmarking`. This method is added for parity with `Ipv4Addr::is_benchmarking`, and I intend to use it in a future rework of `Ipv6Addr::is_global` (edit: rust-lang#86634) to more accurately follow the [IANA Special Address Registry](https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml) (like is done in `Ipv4Addr::is_global`). With `Ipv6Addr::is_benchmarking` and `Ipv4Addr::is_benchmarking` now both existing, `IpAddr::is_benchmarking` is also added.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 4, 2021
…plett Add `Ipv6Addr::is_benchmarking` This PR adds the unstable method `Ipv6Addr::is_benchmarking`. This method is added for parity with `Ipv4Addr::is_benchmarking`, and I intend to use it in a future rework of `Ipv6Addr::is_global` (edit: rust-lang#86634) to more accurately follow the [IANA Special Address Registry](https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml) (like is done in `Ipv4Addr::is_global`). With `Ipv6Addr::is_benchmarking` and `Ipv4Addr::is_benchmarking` now both existing, `IpAddr::is_benchmarking` is also added.
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
4 tasks
|
Ping from triage: |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Aug 22, 2022
…se, r=Mark-Simulacrum Rework Ipv6Addr::is_global to check for global reachability rather than global scope - rebase Rebasing of pull request rust-lang#86634 off of master to try and get the feature "ip" stabilized. I also found a test failure in the rebase that is_global was considering the benchmark space to be globally reachable. This is related to my other rebasing pull request rust-lang#99947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the unstable method
Ipv6Addr::is_globalto make it consistent withIpv4Addr::is_global, checking for reachability rather than global scope (see also #85696 fixing this conflation inIpv6Addr::is_unicast_global).To summarize, there are two concepts; an address can be globally reachable, and an address can have global scope. These concepts have been conflated in the past, but are not the same thing. There exist addresses with global scope that are not globally reachable (for example unique local addresses), and addresses that are globally reachable without having global scope (multicast addresses with non-global scope).
is_unicast_globalshould be used to check for global scope, andis_globalfor global reachability according to the IANA IPv6 Special-Purpose Address Registry, like is done inIpv4Addr::is_globaland other language implementations. (To prevent this confusion in the future, #85696 renamesis_unicast_globaltohas_unicast_global_scope)The documentation of
Ipv4Addr::is_globalis also updated to make the two methods have similar descriptions and examples.